mathdatech/Python
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/Python.git synced 2024-12-18 01:00:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: test failures (#6250)

Browse Source 
1. Incorrect function was being imported from the module
2. Testing for exception was not done correctly
This commit is contained in:
Dhruv Manilawala 2022-07-14 12:54:24 +05:30 committed by GitHub
parent dcc387631d
commit 38dfcd28b5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
maths/miller_rabin.py
View File

@ -8,9 +8,9 @@ from .binary_exp_mod import bin_exp_mod
# if it's not a prime, the chance of it returning true is at most 1/4**prec # if it's not a prime, the chance of it returning true is at most 1/4**prec
def is_prime_big(n, prec=1000): def is_prime_big(n, prec=1000):
""" """
>>> from maths.prime_check import prime_check >>> from maths.prime_check import is_prime
>>> # all(is_prime_big(i) == prime_check(i) for i in range(1000)) # 3.45s >>> # all(is_prime_big(i) == is_prime(i) for i in range(1000)) # 3.45s
>>> all(is_prime_big(i) == prime_check(i) for i in range(256)) >>> all(is_prime_big(i) == is_prime(i) for i in range(256))
True True
""" """
if n < 2: if n < 2:

6
maths/prime_check.py
View File

@ -62,10 +62,8 @@ class Test(unittest.TestCase):
self.assertTrue(is_prime(29)) self.assertTrue(is_prime(29))
def test_not_primes(self): def test_not_primes(self):
self.assertFalse( with self.assertRaises(AssertionError):
is_prime(-19), is_prime(-19)
"Negative numbers are excluded by definition of prime numbers.",
)
self.assertFalse( self.assertFalse(
is_prime(0), is_prime(0),
"Zero doesn't have any positive factors, primes must have exactly two.", "Zero doesn't have any positive factors, primes must have exactly two.",