From 40e357f688c512c0c587f7455b75902c574336a7 Mon Sep 17 00:00:00 2001
From: Grigoriy Hanin <43445998+haningrisha@users.noreply.github.com>
Date: Fri, 4 Jun 2021 23:16:32 +0300
Subject: [PATCH] Mistake in maths/average_mode.py fixed. (#4464)

A serious bug was addressed with this pull request. The mode function previously
didn't return the mode of the input list. Instead, it always returned the first value.
Due to lacking tests, the bug was never caught. This pull request also adds new
functionality to the function, allowing support for more than one mode.

See #4464 for details.

* * Mistake in average_mode.py fixed. The previous solution was to returnthe
value on the first loop iteration, which is not correct, more than that it
used to delete repeating values, so result's array and check array lost
relation between each other

* Type hint added

* redundant check_list deleted

Co-authored-by: Maxim R. <49735721+mrmaxguns@users.noreply.github.com>

* Suggestions resolved

* output typing changed to Any
* test cases added

* Black done

File formatted

* Unused statistics import

statistics only used in doctest, now they are imported in doctest

* Several modes support added

Several modes support added

* Comment fix

* Update maths/average_mode.py

Co-authored-by: Maxim R. <49735721+mrmaxguns@users.noreply.github.com>

* Suggestions added

Co-authored-by: Maxim R. <49735721+mrmaxguns@users.noreply.github.com>
---
 maths/average_mode.py | 40 +++++++++++++++++++++++-----------------
 1 file changed, 23 insertions(+), 17 deletions(-)

diff --git a/maths/average_mode.py b/maths/average_mode.py
index d472dc04d..83db82007 100644
--- a/maths/average_mode.py
+++ b/maths/average_mode.py
@@ -1,7 +1,4 @@
-import statistics
-
-
-def mode(input_list):  # Defining function "mode."
+def mode(input_list: list) -> list:  # Defining function "mode."
     """This function returns the mode(Mode as in the measures of
     central tendency) of the input data.
 
@@ -9,23 +6,32 @@ def mode(input_list):  # Defining function "mode."
 
     >>> input_list = [2, 3, 4, 5, 3, 4, 2, 5, 2, 2, 4, 2, 2, 2]
     >>> mode(input_list)
-    2
-    >>> input_list = [2, 3, 4, 5, 3, 4, 2, 5, 2, 2, 4, 2, 2, 2]
-    >>> mode(input_list) == statistics.mode(input_list)
-    True
+    [2]
+    >>> input_list = [3, 4, 5, 3, 4, 2, 5, 2, 2, 4, 4, 2, 2, 2]
+    >>> mode(input_list)
+    [2]
+    >>> input_list = [3, 4, 5, 3, 4, 2, 5, 2, 2, 4, 4, 4, 2, 2, 4, 2]
+    >>> mode(input_list)
+    [2, 4]
+    >>> input_list = ["x", "y", "y", "z"]
+    >>> mode(input_list)
+    ['y']
+    >>> input_list = ["x", "x" , "y", "y", "z"]
+    >>> mode(input_list)
+    ['x', 'y']
     """
-    # Copying input_list to check with the index number later.
-    check_list = input_list.copy()
     result = list()  # Empty list to store the counts of elements in input_list
     for x in input_list:
         result.append(input_list.count(x))
-        input_list.remove(x)
-        y = max(result)  # Gets the maximum value in the result list.
-        # Returns the value with the maximum number of repetitions.
-        return check_list[result.index(y)]
+    if not result:
+        return []
+    y = max(result)  # Gets the maximum value in the result list.
+    # Gets values of modes
+    result = {input_list[i] for i, value in enumerate(result) if value == y}
+    return sorted(result)
 
 
 if __name__ == "__main__":
-    data = [2, 3, 4, 5, 3, 4, 2, 5, 2, 2, 4, 2, 2, 2]
-    print(mode(data))
-    print(statistics.mode(data))
+    import doctest
+
+    doctest.testmod()