mirror of
https://github.com/TheAlgorithms/Python.git
synced 2024-11-23 21:11:08 +00:00
Update 3n_plus_1.py (#7966)
* Update 3n_plus_1.py 1. Minor issue with ValueError message: Given integer should be positive, not greater than 1, as 1 is allowed. 2. += calls underlying list extend method which might be slower. Calling apend seems more appropriate. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This commit is contained in:
parent
7f1a5521f4
commit
51708530b6
|
@ -11,15 +11,15 @@ def n31(a: int) -> tuple[list[int], int]:
|
|||
if not isinstance(a, int):
|
||||
raise TypeError(f"Must be int, not {type(a).__name__}")
|
||||
if a < 1:
|
||||
raise ValueError(f"Given integer must be greater than 1, not {a}")
|
||||
raise ValueError(f"Given integer must be positive, not {a}")
|
||||
|
||||
path = [a]
|
||||
while a != 1:
|
||||
if a % 2 == 0:
|
||||
a = a // 2
|
||||
a //= 2
|
||||
else:
|
||||
a = 3 * a + 1
|
||||
path += [a]
|
||||
path.append(a)
|
||||
return path, len(path)
|
||||
|
||||
|
||||
|
|
Loading…
Reference in New Issue
Block a user