mathdatech/Python
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/Python.git synced 2024-10-06 13:49:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed error in binary_search_by_recursion

Browse Source 
In binary_search_by_recursion, if you search array for a value that does not exist, you will get this error:
RecursionError: maximum recursion depth exceeded in comparison

To fix this, first check to make sure that the value is between left and right points like this:
    if (right < left):
        return None

A similar construct has already been applied to binary_search, but did not exist in the recursive alternative.
This commit is contained in:
Ant Fitch 2018-01-30 18:50:07 -08:00 committed by GitHub
parent c4234192fa
commit 53681f199c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
searches/binary_search.py
View File

@ -110,6 +110,9 @@ def binary_search_by_recursion(sorted_collection, item, left, right):
>>> binary_search_std_lib([0, 5, 7, 10, 15], 6)
"""
if (right < left):
return None
midpoint = left + (right - left) // 2
if sorted_collection[midpoint] == item: