following recommendations

This commit is contained in:
Margaret 2023-08-02 17:27:39 +03:00
parent 04de01ae05
commit 5e6590b85c

View File

@ -1,7 +1,6 @@
from typing import List, Tuple, Union from typing import List, Tuple, Union
def split_list(timings: List[Union[int, float, str]]) -> Tuple[List[Union[int, float]], List[Union[int, float]], Union[int, float]]:
def split_list(timings: List[Union[int, float, str]]) -> Tuple[List[Union[int, float]]]:
""" """
This algorithm is a brute-force search over (nearly) all 2^n This algorithm is a brute-force search over (nearly) all 2^n
@ -9,7 +8,7 @@ def split_list(timings: List[Union[int, float, str]]) -> Tuple[List[Union[int, f
the asymptotic runtime of this code is: O(n * 2^n) the asymptotic runtime of this code is: O(n * 2^n)
this is a case of the partition problem. this is a case of the partition problem.
it accepts a multiset ( list ) of positive integers, it accepts a multiset ( list ) of integers,
distributes them, and returns a tuple, containing two lists, distributes them, and returns a tuple, containing two lists,
with minimal difference between their sums with minimal difference between their sums
@ -25,7 +24,7 @@ def split_list(timings: List[Union[int, float, str]]) -> Tuple[List[Union[int, f
([10, 11], [12.5, 9], 0.5) ([10, 11], [12.5, 9], 0.5)
>>> split_list(["twelve", "ten", "eleven", "nine"]) >>> split_list(["twelve", "ten", "eleven", "nine"])
Traceback (most recent call last): Traceback (most recent call last):
ValueError: only numbers please ValueError: Timings must be a list of numbers
""" """
@ -42,13 +41,13 @@ def split_list(timings: List[Union[int, float, str]]) -> Tuple[List[Union[int, f
elif isinstance(current_element, (int, float)): elif isinstance(current_element, (int, float)):
timings[i] = abs(current_element) timings[i] = abs(current_element)
else: else:
raise ValueError("only numbers please") raise ValueError("Timings must be a list of numbers")
if len(timings) == 0: if len(timings) == 0:
return ([], [], 0) return ([], [], 0)
elif len(timings) == 1: elif len(timings) == 1:
return ([timings[0]], [], 1) return ([timings[0]], [], timings[0])
else:
result = None result = None
n = len(timings) n = len(timings)
smallest_diff = float("inf") smallest_diff = float("inf")