diff --git a/quantum/shor_algorithm.py b/quantum/shor_algorithm.py index 96a5b3205..9c43ce3b3 100644 --- a/quantum/shor_algorithm.py +++ b/quantum/shor_algorithm.py @@ -6,10 +6,12 @@ Shor Algorithm is one of the basic quantum computing algorithm that is used in breaking the RSA cryptography protocol, by finding the prime numbers that are used to create the public key value, n -In this implementation, I have used a very simple construct without +In this implementation, I have used a very simple construct without the use of qiskit or cirq to help understand how Shor algorithm's idea actually works. """ + + class Shor: def period_find(self, num: int, number: int) -> int: """ @@ -21,12 +23,12 @@ class Shor: >>> shor.period_find(3, 7) 6 """ - start:int = 1 + start: int = 1 while pow(num, start, number) != 1: start += 1 return start - - def shor_algorithm(self, number:int) -> list[int]: + + def shor_algorithm(self, number: int) -> list[int]: """ Run Shor's algorithm to factor a number. >>> shor = Shor() @@ -37,28 +39,24 @@ class Shor: >>> factors (3, 5) """ - if number%2 == 0: - return 2, number//2 + if number % 2 == 0: + return 2, number // 2 while True: random.seed(0) - num:int = random.randint(2, number-1) - gcd_number_num:int = math.gcd(number, num) + num: int = random.randint(2, number - 1) + gcd_number_num: int = math.gcd(number, num) if gcd_number_num > 1: - return gcd_number_num, number//gcd_number_num - - result:int = self.period_find(num, number) - if not result%2: - start:int = pow(num, result//2, number) - if start != number-1: - p_value:int = math.gcd(start-1, number) - q_value:int = math.gcd(start+1, number) + return gcd_number_num, number // gcd_number_num + + result: int = self.period_find(num, number) + if not result % 2: + start: int = pow(num, result // 2, number) + if start != number - 1: + p_value: int = math.gcd(start - 1, number) + q_value: int = math.gcd(start + 1, number) if p_value > 1 and q_value > 1: return p_value, q_value - + shor = Shor() print(shor.shor_algorithm(15)) - - - - \ No newline at end of file