Enable ruff SIM102 rule (#11341)

* Enable ruff SIM102 rule

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

data_structures/arrays/sudoku_solver.py

@@ -92,9 +92,8 @@ def eliminate(values, s, d):
         dplaces = [s for s in u if d in values[s]]
         if len(dplaces) == 0:
             return False  ## Contradiction: no place for this value
-        elif len(dplaces) == 1:
         # d can only be in one place in unit; assign it there
-            if not assign(values, dplaces[0], d):
+        elif len(dplaces) == 1 and not assign(values, dplaces[0], d):
             return False
     return values
 

data_structures/stacks/balanced_parentheses.py

@@ -19,8 +19,9 @@ def balanced_parentheses(parentheses: str) -> bool:
     for bracket in parentheses:
         if bracket in bracket_pairs:
             stack.push(bracket)
-        elif bracket in (")", "]", "}"):
+        elif bracket in (")", "]", "}") and (
-            if stack.is_empty() or bracket_pairs[stack.pop()] != bracket:
+            stack.is_empty() or bracket_pairs[stack.pop()] != bracket
+        ):
             return False
     return stack.is_empty()
 

graphs/a_star.py

@@ -75,8 +75,14 @@ def search(
                 for i in range(len(DIRECTIONS)):  # to try out different valid actions
                     x2 = x + DIRECTIONS[i][0]
                     y2 = y + DIRECTIONS[i][1]
-                    if x2 >= 0 and x2 < len(grid) and y2 >= 0 and y2 < len(grid[0]):
+                    if (
-                        if closed[x2][y2] == 0 and grid[x2][y2] == 0:
+                        x2 >= 0
+                        and x2 < len(grid)
+                        and y2 >= 0
+                        and y2 < len(grid[0])
+                        and closed[x2][y2] == 0
+                        and grid[x2][y2] == 0
+                    ):
                         g2 = g + cost
                         f2 = g2 + heuristic[x2][y2]
                         cell.append([f2, g2, x2, y2])

graphs/bi_directional_dijkstra.py

@@ -36,8 +36,10 @@ def pass_and_relaxation(
             queue.put((new_cost_f, nxt))
             cst_fwd[nxt] = new_cost_f
             parent[nxt] = v
-        if nxt in visited_backward:
+        if (
-            if cst_fwd[v] + d + cst_bwd[nxt] < shortest_distance:
+            nxt in visited_backward
+            and cst_fwd[v] + d + cst_bwd[nxt] < shortest_distance
+        ):
             shortest_distance = cst_fwd[v] + d + cst_bwd[nxt]
     return shortest_distance
 

other/davis_putnam_logemann_loveland.py

@@ -64,9 +64,8 @@ class Clause:
                 value = model[symbol]
             else:
                 continue
-            if value is not None:
             # Complement assignment if literal is in complemented form
-                if literal.endswith("'"):
+            if value is not None and literal.endswith("'"):
                 value = not value
             self.literals[literal] = value
 

project_euler/problem_033/sol1.py

@@ -44,8 +44,12 @@ def fraction_list(digit_len: int) -> list[str]:
     last_digit = int("1" + "0" * digit_len)
     for num in range(den, last_digit):
         while den <= 99:
-            if (num != den) and (num % 10 == den // 10) and (den % 10 != 0):
+            if (
-                if is_digit_cancelling(num, den):
+                (num != den)
+                and (num % 10 == den // 10)
+                and (den % 10 != 0)
+                and is_digit_cancelling(num, den)
+            ):
                 solutions.append(f"{num}/{den}")
             den += 1
         num += 1

project_euler/problem_037/sol1.py

@@ -85,8 +85,9 @@ def validate(n: int) -> bool:
     >>> validate(3797)
     True
     """
-    if len(str(n)) > 3:
+    if len(str(n)) > 3 and (
-        if not is_prime(int(str(n)[-3:])) or not is_prime(int(str(n)[:3])):
+        not is_prime(int(str(n)[-3:])) or not is_prime(int(str(n)[:3]))
+    ):
         return False
     return True
 

project_euler/problem_107/sol1.py

@@ -81,8 +81,9 @@ class Graph:
         while len(subgraph.vertices) < len(self.vertices):
             min_weight = max(self.edges.values()) + 1
             for edge, weight in self.edges.items():
-                if (edge[0] in subgraph.vertices) ^ (edge[1] in subgraph.vertices):
+                if (edge[0] in subgraph.vertices) ^ (
-                    if weight < min_weight:
+                    edge[1] in subgraph.vertices
+                ) and weight < min_weight:
                     min_edge = edge
                     min_weight = weight
 

project_euler/problem_207/sol1.py

@@ -88,8 +88,10 @@ def solution(max_proportion: float = 1 / 12345) -> int:
             total_partitions += 1
             if check_partition_perfect(partition_candidate):
                 perfect_partitions += 1
-        if perfect_partitions > 0:
+        if (
-            if perfect_partitions / total_partitions < max_proportion:
+            perfect_partitions > 0
+            and perfect_partitions / total_partitions < max_proportion
+        ):
             return int(partition_candidate)
         integer += 1
 

pyproject.toml

@@ -18,7 +18,6 @@ lint.ignore = [    # `ruff rule S101` for a description of that rule
   "S105",     # Possible hardcoded password: 'password'
   "S113",     # Probable use of requests call without timeout -- FIX ME
   "S311",     # Standard pseudo-random generators are not suitable for cryptographic purposes -- FIX ME
-  "SIM102",   # Use a single `if` statement instead of nested `if` statements -- FIX ME
   "SLF001",   # Private member accessed: `_Iterator` -- FIX ME
   "UP038",    # Use `X | Y` in `{}` call instead of `(X, Y)` -- DO NOT FIX
 ]

scheduling/shortest_job_first.py

@@ -37,8 +37,11 @@ def calculate_waitingtime(
     # Process until all processes are completed
     while complete != no_of_processes:
         for j in range(no_of_processes):
-            if arrival_time[j] <= increment_time and remaining_time[j] > 0:
+            if (
-                if remaining_time[j] < minm:
+                arrival_time[j] <= increment_time
+                and remaining_time[j] > 0
+                and remaining_time[j] < minm
+            ):
                 minm = remaining_time[j]
                 short = j
                 check = True

scripts/validate_solutions.py

@@ -71,9 +71,12 @@ def added_solution_file_path() -> list[pathlib.Path]:
 
 
 def collect_solution_file_paths() -> list[pathlib.Path]:
-    if os.environ.get("CI") and os.environ.get("GITHUB_EVENT_NAME") == "pull_request":
     # Return only if there are any, otherwise default to all solutions
-        if filepaths := added_solution_file_path():
+    if (
+        os.environ.get("CI")
+        and os.environ.get("GITHUB_EVENT_NAME") == "pull_request"
+        and (filepaths := added_solution_file_path())
+    ):
         return filepaths
     return all_solution_file_paths()
 

web_programming/emails_from_url.py

@@ -30,10 +30,13 @@ class Parser(HTMLParser):
         if tag == "a":
             # Check the list of defined attributes.
             for name, value in attrs:
-                # If href is defined, and not empty nor # print it.
+                # If href is defined, not empty nor # print it and not already in urls.
-                if name == "href" and value != "#" and value != "":
+                if (
-                    # If not already in urls.
+                    name == "href"
-                    if value not in self.urls:
+                    and value != "#"
+                    and value != ""
+                    and value not in self.urls
+                ):
                     url = parse.urljoin(self.domain, value)
                     self.urls.append(url)