mathdatech/Python
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/Python.git synced 2025-02-25 10:28:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update octal_to_binary.py

Browse Source 
Made the code more efficient
This commit is contained in:
Navanit Nandakumar 2023-08-13 11:22:31 +05:30 committed by GitHub
parent 6e742ab167
commit b8b3b8c593
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 63 additions and 80 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
conversions/octal_to_binary.py
View File

@ -59,33 +59,16 @@ def octal_to_binary(octal: str) -> str:
oct_string = str(octal).strip()
if not oct_string:
raise ValueError("Empty string was passed to the function")
is_negative = oct_string[0] == "-"
is_negative = oct_string.startswith('-')
if is_negative:
oct_string = oct_string[1:]
binary_num = '-0b'
else:
binary_num = '0b'
if not oct_string.isdigit() or not all(0 <= int(char) <= 7 for char in oct_string):
raise ValueError("Non-octal value was passed to the function")
decimal_number = 0
for char in oct_string:
decimal_number = 8 * decimal_number + int(char)
if is_negative:
decimal_number = -decimal_number
# Converting Decimal to Binary
if decimal_number == 0:
return "0b0"
negative = False
if decimal_number < 0:
negative = True
decimal_number = -decimal_number
binary: list[int] = []
while decimal_number > 0:
binary.insert(0, decimal_number % 2)
decimal_number >>= 1
if negative:
return "-0b" + "".join(str(e) for e in binary)
return "0b" + "".join(str(e) for e in binary)
binary_num += str(bin(int(oct_string, 8)))[2:]
return binary_num
if __name__ == "__main__":
from doctest import testmod
testmod()