From d687030d9e582534c850493ebc8a22fb4cf1ec81 Mon Sep 17 00:00:00 2001
From: Du Yuanchao <shellhub.me@gmail.com>
Date: Thu, 13 Aug 2020 00:32:35 +0800
Subject: [PATCH] fix number_of_digits bug (#2301)

* fix bug

* test larger negative

* fixup! Format Python code with psf/black push

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
---
 .../binary_tree/basic_binary_tree.py          |  1 +
 maths/number_of_digits.py                     | 28 +++++++++++++++++--
 2 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/data_structures/binary_tree/basic_binary_tree.py b/data_structures/binary_tree/basic_binary_tree.py
index 555305675..575b157ee 100644
--- a/data_structures/binary_tree/basic_binary_tree.py
+++ b/data_structures/binary_tree/basic_binary_tree.py
@@ -5,6 +5,7 @@ class Node:
     """
     A Node has data variable and pointers to Nodes to its left and right.
     """
+
     def __init__(self, data: int) -> None:
         self.data = data
         self.left: Optional[Node] = None
diff --git a/maths/number_of_digits.py b/maths/number_of_digits.py
index ca4cce876..3c0eb7b38 100644
--- a/maths/number_of_digits.py
+++ b/maths/number_of_digits.py
@@ -10,11 +10,20 @@ def num_digits(n: int) -> int:
     5
     >>> num_digits(123)
     3
+    >>> num_digits(0)
+    1
+    >>> num_digits(-1)
+    1
+    >>> num_digits(-123456)
+    6
     """
     digits = 0
-    while n > 0:
+    n = abs(n)
+    while True:
         n = n // 10
         digits += 1
+        if n == 0:
+            break
     return digits
 
 
@@ -27,8 +36,14 @@ def num_digits_fast(n: int) -> int:
     5
     >>> num_digits_fast(123)
     3
+    >>> num_digits_fast(0)
+    1
+    >>> num_digits_fast(-1)
+    1
+    >>> num_digits_fast(-123456)
+    6
     """
-    return math.floor(math.log(abs(n), 10) + 1)
+    return 1 if n == 0 else math.floor(math.log(abs(n), 10) + 1)
 
 
 def num_digits_faster(n: int) -> int:
@@ -40,6 +55,12 @@ def num_digits_faster(n: int) -> int:
     5
     >>> num_digits_faster(123)
     3
+    >>> num_digits_faster(0)
+    1
+    >>> num_digits_faster(-1)
+    1
+    >>> num_digits_faster(-123456)
+    6
     """
     return len(str(abs(n)))
 
@@ -133,3 +154,6 @@ if __name__ == "__main__":
     medium_num = 1125899906842624
     large_num = 1267650600228229401496703205376
     benchmark()
+    import doctest
+
+    doctest.testmod()