mathdatech/Python
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/Python.git synced 2024-11-23 21:11:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixed error in factorial.py (#1888)

Browse Source 
* Update factorial.py

* updating DIRECTORY.md

* Update dynamic_programming/factorial.py

* Update factorial.py

Co-authored-by: mateuszz0000 <mtszzwdzk@gmail.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
This commit is contained in:
Sanders Lin 2020-08-05 19:18:41 +08:00 committed by GitHub
parent 871f8f4e00
commit f0d7879a11
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
dynamic_programming/factorial.py
View File

@ -1,36 +1,25 @@
# Factorial of a number using memoization # Factorial of a number using memoization
result = [-1] * 10
result[0] = result[1] = 1 from functools import lru_cache
def factorial(num): @lru_cache
def factorial(num: int) -> int:
""" """
>>> factorial(7) >>> factorial(7)
5040 5040
>>> factorial(-1) >>> factorial(-1)
'Number should not be negative.' Traceback (most recent call last):
>>> [factorial(i) for i in range(5)] ...
[1, 1, 2, 6, 24] ValueError: Number should not be negative.
>>> [factorial(i) for i in range(10)]
[1, 1, 2, 6, 24, 120, 720, 5040, 40320, 362880]
""" """
if num < 0: if num < 0:
return "Number should not be negative." raise ValueError("Number should not be negative.")
if result[num] != -1:
return result[num]
else:
result[num] = num * factorial(num - 1)
# uncomment the following to see how recalculations are avoided
# print(result)
return result[num]
return 1 if num in (0, 1) else num * factorial(num - 1)
# factorial of num
# uncomment the following to see how recalculations are avoided
# result=[-1]*10
# result[0]=result[1]=1
# print(factorial(5))
# print(factorial(3))
# print(factorial(7))
if __name__ == "__main__": if __name__ == "__main__":
import doctest import doctest