Fix type errors in permutations (#9007)

* updating DIRECTORY.md

* types(permuations): Rename permute2

* Apply suggestions from code review

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

* fix(permutations): Call permute_recursive

* fix(permutations): Correct permutations order

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

.pre-commit-config.yaml

@@ -16,7 +16,7 @@ repos:
     -   id: auto-walrus
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.0.284
+    rev: v0.0.285
     hooks:
       - id: ruff
 
@@ -46,12 +46,12 @@ repos:
         pass_filenames: false
 
   - repo: https://github.com/abravalheri/validate-pyproject
-    rev: v0.13
+    rev: v0.14
     hooks:
       - id: validate-pyproject
 
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.5.0
+    rev: v1.5.1
     hooks:
       - id: mypy
         args:

DIRECTORY.md

@@ -155,6 +155,7 @@
   * [Hexadecimal To Decimal](conversions/hexadecimal_to_decimal.py)
   * [Length Conversion](conversions/length_conversion.py)
   * [Molecular Chemistry](conversions/molecular_chemistry.py)
+  * [Octal To Binary](conversions/octal_to_binary.py)
   * [Octal To Decimal](conversions/octal_to_decimal.py)
   * [Prefix Conversions](conversions/prefix_conversions.py)
   * [Prefix Conversions String](conversions/prefix_conversions_string.py)

data_structures/arrays/permutations.py

@@ -1,17 +1,16 @@
-def permute(nums: list[int]) -> list[list[int]]:
+def permute_recursive(nums: list[int]) -> list[list[int]]:
     """
     Return all permutations.
-    >>> from itertools import permutations
-    >>> numbers= [1,2,3]
-    >>> all(list(nums) in permute(numbers) for nums in permutations(numbers))
-    True
+
+    >>> permute_recursive([1, 2, 3])
+    [[3, 2, 1], [2, 3, 1], [1, 3, 2], [3, 1, 2], [2, 1, 3], [1, 2, 3]]
     """
-    result = []
-    if len(nums) == 1:
-        return [nums.copy()]
+    result: list[list[int]] = []
+    if len(nums) == 0:
+        return [[]]
     for _ in range(len(nums)):
         n = nums.pop(0)
-        permutations = permute(nums)
+        permutations = permute_recursive(nums)
         for perm in permutations:
             perm.append(n)
         result.extend(permutations)
@@ -19,15 +18,15 @@ def permute(nums: list[int]) -> list[list[int]]:
     return result
 
 
-def permute2(nums):
+def permute_backtrack(nums: list[int]) -> list[list[int]]:
     """
     Return all permutations of the given list.
 
-    >>> permute2([1, 2, 3])
+    >>> permute_backtrack([1, 2, 3])
     [[1, 2, 3], [1, 3, 2], [2, 1, 3], [2, 3, 1], [3, 2, 1], [3, 1, 2]]
     """
 
-    def backtrack(start):
+    def backtrack(start: int) -> None:
         if start == len(nums) - 1:
             output.append(nums[:])
         else:
@@ -36,7 +35,7 @@ def permute2(nums):
                 backtrack(start + 1)
                 nums[start], nums[i] = nums[i], nums[start]  # backtrack
 
-    output = []
+    output: list[list[int]] = []
     backtrack(0)
     return output
 
@@ -44,7 +43,6 @@ def permute2(nums):
 if __name__ == "__main__":
     import doctest
 
-    # use res to print the data in permute2 function
-    res = permute2([1, 2, 3])
+    res = permute_backtrack([1, 2, 3])
     print(res)
     doctest.testmod()