Merge 78929f65f5 into 0040ad47f9

.github/workflows/sphinx.yml

@@ -23,7 +23,7 @@ concurrency:
 
 jobs:
   build_docs:
-    runs-on: ubuntu-24.04-arm
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: astral-sh/setup-uv@v5

.pre-commit-config.yaml

@@ -16,13 +16,13 @@ repos:
       - id: auto-walrus
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.9.3
+    rev: v0.9.1
     hooks:
       - id: ruff
       - id: ruff-format
 
   - repo: https://github.com/codespell-project/codespell
-    rev: v2.4.0
+    rev: v2.3.0
     hooks:
       - id: codespell
         additional_dependencies:

DIRECTORY.md

@@ -377,7 +377,6 @@
   * [Longest Common Subsequence](dynamic_programming/longest_common_subsequence.py)
   * [Longest Common Substring](dynamic_programming/longest_common_substring.py)
   * [Longest Increasing Subsequence](dynamic_programming/longest_increasing_subsequence.py)
-  * [Longest Increasing Subsequence Iterative](dynamic_programming/longest_increasing_subsequence_iterative.py)
   * [Longest Increasing Subsequence O Nlogn](dynamic_programming/longest_increasing_subsequence_o_nlogn.py)
   * [Longest Palindromic Subsequence](dynamic_programming/longest_palindromic_subsequence.py)
   * [Matrix Chain Multiplication](dynamic_programming/matrix_chain_multiplication.py)
@@ -464,7 +463,6 @@
 
 ## Graphics
   * [Bezier Curve](graphics/bezier_curve.py)
-  * [Butterfly Pattern](graphics/butterfly_pattern.py)
   * [Digital Differential Analyzer Line](graphics/digital_differential_analyzer_line.py)
   * [Vector3 For 2D Rendering](graphics/vector3_for_2d_rendering.py)
 

ciphers/trifid_cipher.py

@@ -88,7 +88,7 @@ def __prepare(
         ...
     KeyError: 'Length of alphabet has to be 27.'
 
-    Testing with punctuation not in the given alphabet
+    Testing with punctuations that are not in the given alphabet
 
     >>> __prepare('am i a boy?','abCdeFghijkLmnopqrStuVwxYZ+')
     Traceback (most recent call last):
@@ -128,7 +128,7 @@ def encrypt_message(
     encrypt_message
     ===============
 
-    Encrypts a message using the trifid_cipher. Any punctuatuion chars that
+    Encrypts a message using the trifid_cipher. Any punctuatuions that
     would be used should be added to the alphabet.
 
     PARAMETERS

data_structures/arrays/sudoku_solver.py

@@ -9,9 +9,7 @@ import time
 
 
 def cross(items_a, items_b):
-    """
+    "Cross product of elements in A and elements in B."
-    Cross product of elements in A and elements in B.
-    """
     return [a + b for a in items_a for b in items_b]
 
 
@@ -29,7 +27,7 @@ peers = {s: {x for u in units[s] for x in u} - {s} for s in squares}
 
 
 def test():
-    """A set of unit tests."""
+    "A set of unit tests."
     assert len(squares) == 81
     assert len(unitlist) == 27
     assert all(len(units[s]) == 3 for s in squares)
@@ -49,10 +47,8 @@ def test():
 
 
 def parse_grid(grid):
-    """
+    """Convert grid to a dict of possible values, {square: digits}, or
-    Convert grid to a dict of possible values, {square: digits}, or
+    return False if a contradiction is detected."""
-    return False if a contradiction is detected.
-    """
     ## To start, every square can be any digit; then assign values from the grid.
     values = {s: digits for s in squares}
     for s, d in grid_values(grid).items():
@@ -62,19 +58,15 @@ def parse_grid(grid):
 
 
 def grid_values(grid):
-    """
+    "Convert grid into a dict of {square: char} with '0' or '.' for empties."
-    Convert grid into a dict of {square: char} with '0' or '.' for empties.
-    """
     chars = [c for c in grid if c in digits or c in "0."]
     assert len(chars) == 81
     return dict(zip(squares, chars))
 
 
 def assign(values, s, d):
-    """
+    """Eliminate all the other values (except d) from values[s] and propagate.
-    Eliminate all the other values (except d) from values[s] and propagate.
+    Return values, except return False if a contradiction is detected."""
-    Return values, except return False if a contradiction is detected.
-    """
     other_values = values[s].replace(d, "")
     if all(eliminate(values, s, d2) for d2 in other_values):
         return values
@@ -83,10 +75,8 @@ def assign(values, s, d):
 
 
 def eliminate(values, s, d):
-    """
+    """Eliminate d from values[s]; propagate when values or places <= 2.
-    Eliminate d from values[s]; propagate when values or places <= 2.
+    Return values, except return False if a contradiction is detected."""
-    Return values, except return False if a contradiction is detected.
-    """
     if d not in values[s]:
         return values  ## Already eliminated
     values[s] = values[s].replace(d, "")
@@ -109,9 +99,7 @@ def eliminate(values, s, d):
 
 
 def display(values):
-    """
+    "Display these values as a 2-D grid."
-    Display these values as a 2-D grid.
-    """
     width = 1 + max(len(values[s]) for s in squares)
     line = "+".join(["-" * (width * 3)] * 3)
     for r in rows:
@@ -126,14 +114,11 @@ def display(values):
 
 
 def solve(grid):
-    """
-    Solve the grid.
-    """
     return search(parse_grid(grid))
 
 
 def some(seq):
-    """Return some element of seq that is true."""
+    "Return some element of seq that is true."
     for e in seq:
         if e:
             return e
@@ -141,9 +126,7 @@ def some(seq):
 
 
 def search(values):
-    """
+    "Using depth-first search and propagation, try all possible values."
-    Using depth-first search and propagation, try all possible values.
-    """
     if values is False:
         return False  ## Failed earlier
     if all(len(values[s]) == 1 for s in squares):
@@ -154,11 +137,9 @@ def search(values):
 
 
 def solve_all(grids, name="", showif=0.0):
-    """
+    """Attempt to solve a sequence of grids. Report results.
-    Attempt to solve a sequence of grids. Report results.
     When showif is a number of seconds, display puzzles that take longer.
-    When showif is None, don't display any puzzles.
+    When showif is None, don't display any puzzles."""
-    """
 
     def time_solve(grid):
         start = time.monotonic()
@@ -181,9 +162,7 @@ def solve_all(grids, name="", showif=0.0):
 
 
 def solved(values):
-    """
+    "A puzzle is solved if each unit is a permutation of the digits 1 to 9."
-    A puzzle is solved if each unit is a permutation of the digits 1 to 9.
-    """
 
     def unitsolved(unit):
         return {values[s] for s in unit} == set(digits)
@@ -198,11 +177,9 @@ def from_file(filename, sep="\n"):
 
 
 def random_puzzle(assignments=17):
-    """
+    """Make a random puzzle with N or more assignments. Restart on contradictions.
-    Make a random puzzle with N or more assignments. Restart on contradictions.
     Note the resulting puzzle is not guaranteed to be solvable, but empirically
-    about 99.8% of them are solvable. Some have multiple solutions.
+    about 99.8% of them are solvable. Some have multiple solutions."""
-    """
     values = {s: digits for s in squares}
     for s in shuffled(squares):
         if not assign(values, s, random.choice(values[s])):
@@ -214,9 +191,7 @@ def random_puzzle(assignments=17):
 
 
 def shuffled(seq):
-    """
+    "Return a randomly shuffled copy of the input sequence."
-    Return a randomly shuffled copy of the input sequence.
-    """
     seq = list(seq)
     random.shuffle(seq)
     return seq

data_structures/binary_tree/avl_tree.py

@@ -221,10 +221,6 @@ def del_node(root: MyNode, data: Any) -> MyNode | None:
     else:
         root.set_right(del_node(right_child, data))
 
-    # Re-fetch left_child and right_child references
-    left_child = root.get_left()
-    right_child = root.get_right()
-
     if get_height(right_child) - get_height(left_child) == 2:
         assert right_child is not None
         if get_height(right_child.get_right()) > get_height(right_child.get_left()):

other/doomsday.py

@@ -46,7 +46,7 @@ def get_week_day(year: int, month: int, day: int) -> str:
     ) % 7
     day_anchor = (
         DOOMSDAY_NOT_LEAP[month - 1]
-        if year % 4 != 0 or (centurian == 0 and year % 400 != 0)
+        if (year % 4 != 0) or (centurian == 0 and (year % 400) == 0)
         else DOOMSDAY_LEAP[month - 1]
     )
     week_day = (dooms_day + day - day_anchor) % 7

pyproject.toml

@@ -159,7 +159,7 @@ lint.pylint.max-returns = 8 # default: 6
 lint.pylint.max-statements = 88 # default: 50
 
 [tool.codespell]
-ignore-words-list = "3rt,abd,aer,ans,bitap,crate,damon,fo,followings,hist,iff,kwanza,manuel,mater,secant,som,sur,tim,toi,zar"
+ignore-words-list = "3rt,ans,bitap,crate,damon,fo,followings,hist,iff,kwanza,manuel,mater,secant,som,sur,tim,toi,zar"
 skip = "./.*,*.json,*.lock,ciphers/prehistoric_men.txt,project_euler/problem_022/p022_names.txt,pyproject.toml,strings/dictionary.txt,strings/words.txt"
 
 [tool.pytest.ini_options]

sorts/bubble_sort.py

@@ -85,8 +85,6 @@ def bubble_sort_recursive(collection: list[Any]) -> list[Any]:
     [1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7]
     >>> bubble_sort_recursive([1, 3.3, 5, 7.7, 2, 4.4, 6])
     [1, 2, 3.3, 4.4, 5, 6, 7.7]
-    >>> bubble_sort_recursive(['a', 'Z', 'B', 'C', 'A', 'c'])
-    ['A', 'B', 'C', 'Z', 'a', 'c']
     >>> import random
     >>> collection_arg = random.sample(range(-50, 50), 100)
     >>> bubble_sort_recursive(collection_arg) == sorted(collection_arg)